SWIFT-752 Implement transactions spec test runner #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHeppenstall
force-pushed
the
SWIFT-752/spec-test-runner
branch
2 times, most recently
from
26f57ae to
d4f16e4
Compare
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
==========================================
- Coverage 77.88% 76.33% -1.56%
==========================================
Files 114 116 +2
Lines 12314 12799 +485
==========================================
+ Hits 9591 9770 +179
- Misses 2723 3029 +306
Continue to review full report at Codecov.
|
patrickfreed
reviewed
Apr 7, 2020
patrickfreed
reviewed
Apr 8, 2020
Contributor
patrickfreed
left a comment
patrickfreed
left a comment
There was a problem hiding this comment.
fyi I don't think the latest changes have been pushed up yet
Contributor
Author
Just pushed them :) |
patrickfreed
reviewed
Apr 8, 2020
Tests/MongoSwiftSyncTests/SpecTestRunner/TestOperationResult.swift
Outdated
Show resolved
Hide resolved
Tests/MongoSwiftSyncTests/SpecTestRunner/TestOperationResult.swift
Outdated
Show resolved
Hide resolved
kmahar
reviewed
Apr 8, 2020
JamesHeppenstall
force-pushed
the
SWIFT-752/spec-test-runner
branch
from
133013e to
f912db9
Compare
patrickfreed
reviewed
Apr 9, 2020
Tests/MongoSwiftSyncTests/SpecTestRunner/TestOperationResult.swift
Outdated
Show resolved
Hide resolved
kmahar
reviewed
Apr 9, 2020
Tests/MongoSwiftSyncTests/SpecTestRunner/CodableExtensions.swift
Outdated
Show resolved
Hide resolved
kmahar
reviewed
Apr 10, 2020
Contributor
kmahar
left a comment
kmahar
left a comment
There was a problem hiding this comment.
ok I've gotten through all the files finally, sorry for my delay, but this is looking really good 🙂
Tests/MongoSwiftSyncTests/SpecTestRunner/TestOperationResult.swift
Outdated
Show resolved
Hide resolved
Contributor
patrickfreed
left a comment
patrickfreed
left a comment
There was a problem hiding this comment.
looking good, just have a few more comments about codable stuff
kmahar
reviewed
Apr 10, 2020
kmahar
reviewed
Apr 10, 2020
Contributor
kmahar
left a comment
kmahar
left a comment
There was a problem hiding this comment.
two tiny more things otherwise lgtm
patrickfreed
approved these changes
Apr 10, 2020
Contributor
patrickfreed
left a comment
patrickfreed
left a comment
There was a problem hiding this comment.
LGTM once evergreen / travis come back green (mod the bulk error).
great job on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented everything except the sharding-specific tests (mongos-pin-auto.json, mongos-recovery-token.json, and pin-mongos.json), which I will do in another PR. The retryable reads and transactions tests now run in a unified test runner.