Skip to content

Conversation

@JamesHeppenstall
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 6, 2020

Codecov Report

Merging #444 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #444   +/-   ##
=======================================
  Coverage   76.33%   76.33%           
=======================================
  Files         116      116           
  Lines       12799    12799           
=======================================
  Hits         9770     9770           
  Misses       3029     3029           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2545db0...8161739. Read the comment docs.

@kmahar
Copy link
Contributor

kmahar commented Apr 10, 2020

my bad for not pointing this out before, but we have all of the official docs examples live in the project located at Examples/DocsExamples, so it would be great if we could have the code in there as well. that makes it easy for us to ensure our example code still builds in the future.

that said I think it's a good idea to have a guide in our docs on transaction use too so let's keep the markdown file, and we can expand it with convenient API examples later on.

@JamesHeppenstall JamesHeppenstall force-pushed the SWIFT-423/transactions-guide branch from 4cbd4a8 to a0c8b6f Compare April 10, 2020 18:50
@JamesHeppenstall
Copy link
Contributor Author

Note that the tests to compile the examples will fail until SWIFT-752 is pushed to master. This is because you must currently specify the label options in startTransaction().

@JamesHeppenstall JamesHeppenstall force-pushed the SWIFT-423/transactions-guide branch from ec62b5b to d1a60b8 Compare April 10, 2020 21:31
@JamesHeppenstall JamesHeppenstall force-pushed the SWIFT-423/transactions-guide branch from d1a60b8 to 8161739 Compare April 10, 2020 21:42
@JamesHeppenstall JamesHeppenstall merged commit 18a20bf into master Apr 10, 2020
@JamesHeppenstall JamesHeppenstall deleted the SWIFT-423/transactions-guide branch April 10, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants