SWIFT-773: add authorizedDatabases optional option #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
reviewed
Apr 15, 2020
kmahar
reviewed
Apr 16, 2020
Contributor
|
just occurred to me, you'll need to make these same API changes to support |
kmahar
reviewed
Apr 16, 2020
Contributor
kmahar
left a comment
kmahar
left a comment
There was a problem hiding this comment.
looking good 👍 just a few more nits
kmahar
reviewed
Apr 17, 2020
Sources/MongoSwift/MongoClient.swift
Outdated
| * - `LogicError` if the provided session is inactive. | ||
| * - `LogicError` if this client has already been closed. | ||
| * - `EncodingError` if an error is encountered while encoding the options to BSON. | ||
| * - `CommandError` when options.authorizedDatabases is false: |
Contributor
There was a problem hiding this comment.
sorry to be pedantic...
-
can we phrase this more similarly to the previous bullet points? by that I mean the "
CommandErrorif ...". format. so something like "if options.authorizedDatabases is false and the user does not have listDatabases permissions." -
listDatabase -> listDatabases
patrickfreed
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
authorizedDatabasesoption to ListDatabasesOperation as an optional param. No changes needed to the helpers.Check out the flag docs here