SWIFT-784 Disable BSON_EXTRA_ALIGN #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
patrickfreed
left a comment
patrickfreed
left a comment
There was a problem hiding this comment.
very excited for this. When I tried to disable this locally a long time ago, I didn't know about the single flag and figured it would be a lot of work, happy to see that it wasn't.
mbroadst
approved these changes
Apr 16, 2020
patrickfreed
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done experimentally while investigating the C interop issue in SWIFT-779.
The required changes ended up being pretty minimal so we should just go ahead with them now.