Skip to content

Conversation

@patrickfreed
Copy link
Contributor

SWIFT-423

This PR adds the examples to be rendered in the official MongoDB docs page on transactions usage in drivers.

@patrickfreed patrickfreed requested review from kmahar and nbbeeken May 20, 2020 19:10
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #478 into master will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
- Coverage   76.96%   76.86%   -0.11%     
==========================================
  Files         125      125              
  Lines       12991    12995       +4     
==========================================
- Hits         9999     9988      -11     
- Misses       2992     3007      +15     
Impacted Files Coverage Δ
Tests/MongoSwiftSyncTests/CrudTests.swift 90.90% <0.00%> (-5.69%) ⬇️
Sources/MongoSwift/MongoCollection+Write.swift 97.89% <0.00%> (ø)
Sources/MongoSwift/MongoCollection+BulkWrite.swift 85.62% <0.00%> (ø)
Sources/MongoSwift/ConnectionPool.swift 60.97% <0.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f01e15a...45963ce. Read the comment docs.

Copy link
Contributor

@kmahar kmahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, lgtm otherwise

@patrickfreed patrickfreed merged commit eb67196 into mongodb:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants