Skip to content

Conversation

@kmahar
Copy link
Contributor

@kmahar kmahar commented May 24, 2020

Renames all public and internal methods of the form asX to toX.

Relatedly I remembered while doing this that we had decided in the BSON design doc we would switch to using toX methods for BSON interop with other types, rather than adding initializers to types we don't own. But I forgot to add that to the list Neal did in #477. I went ahead and moved the BSONBinary -> UUID logic into BSONBinary.toUUID, and the BSONRegularExpression -> NSRegularExpression logic into BSONRegularExpression.toNSRegularExpression.

@kmahar kmahar requested review from nbbeeken and patrickfreed May 24, 2020 20:53
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2020

Codecov Report

Merging #484 into master will decrease coverage by 0.00%.
The diff coverage is 94.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
- Coverage   76.87%   76.86%   -0.01%     
==========================================
  Files         125      125              
  Lines       13003    12999       -4     
==========================================
- Hits         9996     9992       -4     
  Misses       3007     3007              
Impacted Files Coverage Δ
...MongoSwiftSyncTests/SpecTestRunner/FailPoint.swift 7.35% <0.00%> (ø)
...sts/MongoSwiftSyncTests/SpecTestRunner/Match.swift 37.25% <0.00%> (ø)
...ts/MongoSwiftSyncTests/SyncChangeStreamTests.swift 26.82% <0.00%> (ø)
Tests/MongoSwiftSyncTests/SyncTestUtils.swift 60.20% <0.00%> (ø)
Sources/MongoSwift/MongoError.swift 60.69% <66.66%> (ø)
Sources/MongoSwift/BSON/BSON.swift 80.59% <100.00%> (ø)
Sources/MongoSwift/BSON/BSONDecoder.swift 66.18% <100.00%> (ø)
Sources/MongoSwift/BSON/BSONEncoder.swift 64.54% <100.00%> (ø)
Sources/MongoSwift/BSON/BSONValue.swift 76.00% <100.00%> (-0.17%) ⬇️
Sources/MongoSwift/MongoCollection+BulkWrite.swift 85.62% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b1729...35eb22e. Read the comment docs.

@kmahar kmahar merged commit 8192ef9 into master May 26, 2020
@kmahar kmahar deleted the SWIFT-835/conversion-method-names branch May 26, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants