SWIFT-835 Standardize on conversion method names #484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames all public and internal methods of the form
asXtotoX.Relatedly I remembered while doing this that we had decided in the BSON design doc we would switch to using
toXmethods for BSON interop with other types, rather than adding initializers to types we don't own. But I forgot to add that to the list Neal did in #477. I went ahead and moved theBSONBinary->UUIDlogic intoBSONBinary.toUUID, and theBSONRegularExpression->NSRegularExpressionlogic intoBSONRegularExpression.toNSRegularExpression.