Patch in necessary libmongoc fixes for 1.0 #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
=======================================
Coverage 76.89% 76.89%
=======================================
Files 125 125
Lines 13012 13012
=======================================
Hits 10005 10005
Misses 3007 3007 Continue to review full report at Codecov.
|
nbbeeken
approved these changes
May 27, 2020
Contributor
nbbeeken
left a comment
nbbeeken
left a comment
There was a problem hiding this comment.
looking at a diff of diff is so meta
mbroadst
approved these changes
May 27, 2020
Member
mbroadst
left a comment
mbroadst
left a comment
There was a problem hiding this comment.
LGTM, glad this was less painful than I anticipated 😅
patrickfreed
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our vendoring script to apply two patches to CLibMongoC, and also brings in the results of running the updated script.
successful patch: https://evergreen.mongodb.com/version/5ecd7264306615532c0d77cb
and libmongoc patch confirming that all their tests pass with 1.16 + these patches applied: https://evergreen.mongodb.com/version/5ecdaf2132f417195909fc40 (@kevinAlbs says it safe to ignore the debian-package-build and rpm-package-build failures)
Work to give us the new behavior (unspecified directConnection is treated as if it's set to false) will come in a follow-up PR.