SWIFT-1072 Improve result parsing performance #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
reviewed
Jan 27, 2021
| for upsert in upserted.compactMap({ $0.documentValue }) { | ||
| guard let index = upsert["index"]?.toInt() else { | ||
| throw MongoError.InternalError(message: "Could not cast upserted index to `Int`") | ||
| var seenKey = true |
Contributor
There was a problem hiding this comment.
is this supposed to start out as false?
Contributor
Author
There was a problem hiding this comment.
oh yep, good catch, fixed.
| guard let index = upsert["index"]?.toInt() else { | ||
| throw MongoError.InternalError(message: "Could not cast upserted index to `Int`") | ||
| var seenKey = true | ||
| for (k, v) in reply { |
Contributor
There was a problem hiding this comment.
suggest adding a comment somewhere indicating that this method is written this way for perf reasons so we can do it in a single pass, seems maybe easy to forget otherwise
kmahar
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIFT-1072
This PR contains the driver-side changes of SWIFT-1072. This also is the only change required for the find performance improvements as well, making this the last PR of SWIFT-993.
Benchmark results (insertion ones copied from PR on
swift-bson):