Fix txn tests #599
Merged
Fix txn tests #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
update: there were a few macOS failures but they are all due to the libmongoc crashing on sigpipe issue so those will be fixed by vendoring in 1.17.4. |
patrickfreed
approved these changes
Feb 5, 2021
Contributor
patrickfreed
left a comment
patrickfreed
left a comment
There was a problem hiding this comment.
one nit/suggestion but otherwise LGTM (don't need to review again).
great job hunting down these failures!
| // Due to strange behavior in mongos, a "distinct" command needs to be run against each mongos | ||
| // before the tests run to prevent certain errors from ocurring. (SERVER-39704) | ||
| if MongoSwiftTestCase.topologyType == .sharded, | ||
| if [.sharded, .shardedReplicaSet].contains(topologyType), |
Contributor
There was a problem hiding this comment.
Since this will likely be quite common, could we add an isSharded (or something similar) method to TopologyType?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the transactions test failures by using separate clients for running specific commands against each mongos. As discussed in #driver-devs, this accounts for cases where the setup client has not yet reconnected to one of the mongoses after a test.
I thought about porting this over to the unified runner, but that one is fairly specific that the internal client should be used for terminating open transactions and doesn't appear to be suffering from this issue on its own. It may become necessary in the future if any similarly racy tests start using that runner.
Evg patch against all sharded variants (realized those < 4.2 were useless too late): https://evergreen.mongodb.com/version/601c817c850e612ab835c3c9
no macOS results in yet but as you can see this has fixed all the Ubuntu failures anyway.