SWIFT-1326 Run load balancer spec tests #669
Conversation
| asType: UnifiedTestFile.self | ||
| ).filter { $0.0 == "cursors.json" }.map { $0.1 } | ||
|
|
||
| let skipTests = [ |
There was a problem hiding this comment.
unfortunately a lot of caveats here, but we still do get to run a decent number of the tests, so it seems better than nothing. let me know if all the reasoning below makes sense.
There was a problem hiding this comment.
All the skip reasons seem clear and detailed, LGTM.
| case .command: | ||
| self.events = try container.decode([ExpectedEvent].self, forKey: .events) | ||
| case .cmap: | ||
| // TODO: SWIFT-1321 actually parse these out. |
There was a problem hiding this comment.
for now, there is just always an empty array, and in the runner below if ExpectedEventsForClient.type is cmap we skip doing assertions as we don't capture any events.
| } | ||
| } | ||
|
|
||
| struct UnifiedListIndexes: UnifiedOperationProtocol { |
There was a problem hiding this comment.
we don't actually end up using this operation since we skip the listIndexes cursor test, but I figured we would need it eventually and adding it seemed like a reasonable way to allow us to decode cursors.json
| } | ||
| } | ||
|
|
||
| struct UnifiedListCollections: UnifiedOperationProtocol { |
There was a problem hiding this comment.
similarly, this operation ends up going unused but I added it for completeness.
patrickfreed
left a comment
patrickfreed
left a comment
There was a problem hiding this comment.
one typo fix but otherwise LGTM
| asType: UnifiedTestFile.self | ||
| ).filter { $0.0 == "cursors.json" }.map { $0.1 } | ||
|
|
||
| let skipTests = [ |
There was a problem hiding this comment.
All the skip reasons seem clear and detailed, LGTM.
Tests/MongoSwiftSyncTests/UnifiedTestRunner/UnifiedCollectionOperations.swift
Outdated
Show resolved
Hide resolved
kmahar
force-pushed
the
SWIFT-1326/run-lb-spec-tests
branch
from
9102ddc to
a4b16a0
Compare
[this is currently based on the Evergreen testing PR, I think GitHub will automatically update the base once that goes in]
This adds code to actually start running the new tests, as well as making some various unified runner / testing infrastructure changes to support it.
patch