Skip to content

CLOUDP-113292: Update repo references in new release alert feature #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2022
Merged

CLOUDP-113292: Update repo references in new release alert feature #1022

merged 1 commit into from
Mar 7, 2022

Conversation

@andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Mar 7, 2022 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-113292

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

I have tested that the feature still works

./bin/mongocli config ls
A new version of mongocli is available 'v1.23.0'!
To upgrade, see: https://dochub.mongodb.org/core/mongocli-install.
To disable this alert, run "mongocli config set skip_update_check true".

@andreaangiolillo andreaangiolillo changed the title CLOUDP-113292: Update release_version.go CLOUDP-113292: Update repo references in new release alert feature Mar 7, 2022
@andreaangiolillo andreaangiolillo requested a review from blva March 7, 2022 17:30
@andreaangiolillo andreaangiolillo marked this pull request as ready for review March 7, 2022 17:30
@andreaangiolillo andreaangiolillo requested a review from a team March 7, 2022 17:30
blva
blva approved these changes Mar 7, 2022
View reviewed changes
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit ff402bc into master Mar 7, 2022
@andreaangiolillo andreaangiolillo deleted the CLOUDP-113292 branch March 7, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blva blva blva approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreaangiolillo @blva