Skip to content

CLOUDP-117256: Improve expired code handling #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2022
Merged

CLOUDP-117256: Improve expired code handling #1093

merged 1 commit into from
Mar 30, 2022

Conversation

@gssbzn
Copy link
Contributor

@gssbzn gssbzn commented Mar 30, 2022 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-117256

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

./bin/mongocli login

First, copy your one-time code: DWXF-R48Q

Next, sign in with your browser and enter the code.

Or go to https://account.mongodb.com/account/connect

Your code will expire after 10 minutes.
Error: authentication timed out

@gssbzn gssbzn requested a review from a team March 30, 2022 18:23
andreaangiolillo
andreaangiolillo approved these changes Mar 30, 2022
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn merged commit 925b351 into master Mar 30, 2022
@gssbzn gssbzn deleted the CLOUDP-117256 branch March 30, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gssbzn @andreaangiolillo