Skip to content

CLOUDP-125776: Some errors are not being tracked #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2022
Merged

CLOUDP-125776: Some errors are not being tracked #1304

merged 1 commit into from
Jun 10, 2022

Conversation

@fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Jun 10, 2022

Proposed changes

Some errors are not being tracked

Jira ticket: CLOUDP-125776

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@fmenezes fmenezes requested a review from a team June 10, 2022 15:24
swattyT
swattyT approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@swattyT swattyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ciprian-tibulca
ciprian-tibulca reviewed Jun 10, 2022
View reviewed changes
@fmenezes fmenezes merged commit 9cd6011 into master Jun 10, 2022
@fmenezes fmenezes deleted the CLOUDP-125776 branch June 10, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ciprian-tibulca ciprian-tibulca ciprian-tibulca approved these changes

+1 more reviewer

@swattyT swattyT swattyT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fmenezes @ciprian-tibulca @swattyT