CLOUDP-148788: [AtlasCLI] cutover command is using orgId instead of projectId #1543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
previously approved these changes
Dec 2, 2022
colm-quinn
reviewed
Dec 2, 2022
| PreRunE: func(cmd *cobra.Command, args []string) error { | ||
| return opts.PreRunE( | ||
| opts.ValidateOrgID, | ||
| opts.ValidateProjectID, |
Collaborator
There was a problem hiding this comment.
Well done here on the prompt reply.
Not blocking: Can you do a quick audit of the other LiveMigration commands to make sure they are using the correct parameter? Patterns like this tend to happen in multiple places easily, so would be good to confirm in case it's in other places.
andreaangiolillo
dismissed stale reviews from colm-quinn, blva, and gssbzn
via
edb910a
gssbzn
reviewed
Dec 5, 2022
|
|
||
| func (opts *LiveMigrationsOpts) GenerateFlags(cmd *cobra.Command) { | ||
| cmd.Flags().StringVar(&opts.OrgID, flag.OrgID, "", usage.OrgID) | ||
| cmd.Flags().StringVar(&opts.ProjectID, flag.ProjectID, "", usage.ProjectID) |
Contributor
There was a problem hiding this comment.
line 128, there's a built in feature now for that can you migrate to it
blva
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-148788
Checklist
make fmtand formatted my codeFurther comments
This came out in https://jira.mongodb.org/browse/HELP-40211. The cutover command is passing the
orgIdinstead of theprojectId