CLOUDP-341161: accesslogs list did not pass opts to apiRequest #4163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
reviewed
Aug 26, 2025
| if opts.Start != "" { | ||
| startTime, _ := strconv.ParseInt(opts.Start, 10, 64) | ||
| result.Start(startTime) | ||
| result = result.Start(startTime) |
There was a problem hiding this comment.
[q] could we extend some of our e2e tests to cover this custom configuration? (start/end time)
There was a problem hiding this comment.
I intend to open a separate ticket to prioritize this bug fix since I think an expansion of the e2e tests will require some additional logic to modify a cluster on the data plane to populate the logs before running accesslogs list.
There was a problem hiding this comment.
@blva FYI, ticket opened: https://jira.mongodb.org/browse/CLOUDP-341212
blva
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR addresses a bug in accesslogs list in which the apiRequest was not being correctly populated with flag opts. This results in flags like
--startand--endto be ignored. This is because the setter functions the SDK provides don't modify the apiRequest calling the setter, but instead returns a new apiRequest which is teh calling apiRequest + the opts set.This fix has been tested manually.
Behaviour before:
All logs would be printed, regardless of flags set.
Behaviour after:
Logs are printed in accordance to flags set.
Jira ticket: CLOUDP-341161