Skip to content

Conversation

@gssbzn
Copy link
Contributor

@gssbzn gssbzn commented Jul 7, 2021

Proposed changes

Jira ticket: CLOUDP-94311

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if a new command or e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

Genertae docs on release and include on our internal announcement a link to it so docs can easily grave them

@gssbzn gssbzn requested review from a team and drinkbird and removed request for a team July 7, 2021 09:53
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn merged commit abc15cc into master Jul 7, 2021
@gssbzn gssbzn deleted the CLOUDP-94311 branch July 7, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants