Skip to content

Conversation

@colm-quinn
Copy link
Collaborator

Proposed changes

Support for "Return Status of One Specific Validation Job" Docs

Jira ticket: CLOUDP-97428

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if a new command or e2e test has been added)
  • I have run make fmt and formatted my code

Command Help:

bin/mongocli atlas lm validation describe --help --profile=atlas-dev                  
Your API Key must have the Organization Owner role to successfully run this command.

Usage:
  mongocli atlas liveMigrations validation describe [flags]

Aliases:
  describe, get

Flags:
  -h, --help                  help for describe
  -o, --output string         Output format.
                              Valid values: json|json-path|go-template|go-template-file
      --projectId string      Project ID to use. Overrides configuration file or environment variable settings.
      --validationId string   Unique 24-hexadecimal digit string that identifies the validation job.

Command output:

bin/mongocli atlas lm validation describe --validationId=6141c02eadd36135e7414ac3 -o=json --profile=atlas-dev
{
  "_id": "6141c02eadd36135e7414ac3",
  "groupId": "6137493677e94f0e973d1a0f",
  "status": "PENDING",
  "sourceGroupId": "611e68cb086adf5cda2e6253"
}

@colm-quinn colm-quinn requested a review from a team as a code owner September 15, 2021 10:13
@colm-quinn colm-quinn requested review from a team and fmenezes September 15, 2021 10:13
cmd.Flags().StringVar(&opts.DestinationClusterName, flag.ClusterName, "", usage.LiveMigrationDestinationClusterName)
cmd.Flags().StringSliceVar(&opts.MigrationHosts, flag.LiveMigrationHost, []string{}, usage.LiveMigrationHostEntries)
cmd.Flags().BoolVar(&opts.DestinationDropEnabled, flag.LiveMigrationDropCollections, false, usage.LiveMigrationDropCollections)
cmd.Flags().StringVarP(&opts.Output, flag.Output, flag.OutputShort, "", usage.FormatOut)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[flyby] Allowing json output for the live migration commands

Copy link
Collaborator

@fmenezes fmenezes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just blocking on one comment

Copy link
Collaborator

@fmenezes fmenezes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@gssbzn gssbzn merged commit dde89d6 into master Sep 16, 2021
@gssbzn gssbzn deleted the CLOUDP-97432 branch September 16, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants