Skip to content

HELP-28512: mongocli cannot handle net.tls.FIPSMode properly #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2021
Merged

HELP-28512: mongocli cannot handle net.tls.FIPSMode properly #893

merged 1 commit into from
Oct 20, 2021

Conversation

@andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Oct 20, 2021 •
edited
Loading

Proposed changes

Jira ticket: HELP-28512

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if a new command or e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo requested review from a team, colm-quinn and gssbzn October 20, 2021 13:45
gssbzn
gssbzn approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit 7ac9be8 into master Oct 20, 2021
@andreaangiolillo andreaangiolillo deleted the HELP-28512 branch October 20, 2021 13:58
@gssbzn
Copy link
Contributor

gssbzn commented Oct 20, 2021

@andreaangiolillo I scheduled the Ops manager tests to deploy clusters, let's confirm those pass before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colm-quinn colm-quinn Awaiting requested review from colm-quinn

1 more reviewer

@gssbzn gssbzn gssbzn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreaangiolillo @gssbzn