Skip to content

Conversation

@helderjs
Copy link
Collaborator

@helderjs helderjs commented Nov 14, 2025

Summary

  • This fix a typo where main handler struct have group as variable name for all methods
  • This handle nil condition for connection secret when build client secret
  • This split generator methods in more specific files for better readability and maintance

Proof of Work

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@helderjs helderjs requested a review from a team as a code owner November 14, 2025 11:26
@josvazg
Copy link
Collaborator

josvazg commented Nov 14, 2025

Can you add more context on what this is about and why is it required in the description?
Couple of paragraphs would suffice.
I want to build more context on the scaffolder and the pipeline.

@helderjs
Copy link
Collaborator Author

Can you add more context on what this is about and why is it required in the description? Couple of paragraphs would suffice. I want to build more context on the scaffolder and the pipeline.

Done

@helderjs helderjs merged commit ac11e93 into main Nov 14, 2025
2 checks passed
@helderjs helderjs deleted the CLOUDP-359440-fix-handler branch November 14, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants