Skip to content

Fixed URL for the atlas operator client #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2022
Merged

Fixed URL for the atlas operator client #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b673051
Fixed URL for the atlas operator client
igor-karpukhin Mar 3, 2022
61b700b
Fixed commit
igor-karpukhin Mar 3, 2022
2bebeec
Fixed e2e test flow
igor-karpukhin Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ jobs:

- name: Change path for the test
run: |
sed -i -e 's/cloud.mongodb.com/cloud-qa.mongodb.com\//' bundle/manifests/mongodb-atlas-kubernetes.clusterserviceversion.yaml
awk '{gsub(/cloud.mongodb.com/, "cloud-qa.mongodb.com", $0); print}' bundle/manifests/mongodb-atlas-kubernetes.clusterserviceversion.yaml > tmp && mv tmp bundle/manifests/mongodb-atlas-kubernetes.clusterserviceversion.yaml

- name: Push bundle-image for the test
if: ${{ matrix.test == 'openshift' || matrix.test == 'bundle-test' && !env.ACT }}
Expand Down
2 changes: 1 addition & 1 deletion cmd/manager/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ type Config struct {
func parseConfiguration(log *zap.SugaredLogger) Config {
var globalAPISecretName string
config := Config{}
flag.StringVar(&config.AtlasDomain, "atlas-domain", "https://cloud.mongodb.com", "the Atlas URL domain name (no slash in the end).")
flag.StringVar(&config.AtlasDomain, "atlas-domain", "https://cloud.mongodb.com/", "the Atlas URL domain name (with slash in the end).")
flag.StringVar(&config.MetricsAddr, "metrics-bind-address", ":8080", "The address the metric endpoint binds to.")
flag.StringVar(&config.ProbeAddr, "health-probe-bind-address", ":8081", "The address the probe endpoint binds to.")
flag.StringVar(&globalAPISecretName, "global-api-secret-name", "", "The name of the Secret that contains Atlas API keys. "+
Expand Down
2 changes: 1 addition & 1 deletion config/release/prod/prod_patch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[
{"op": "add",
"path": "/spec/template/spec/containers/0/args/0",
"value": "--atlas-domain=https://cloud.mongodb.com"
"value": "--atlas-domain=https://cloud.mongodb.com/"
}
]
Copy link
Contributor

@fabritsius fabritsius Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor thing