CLOUDP-78181: ip access list (part 3) #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 25, 2021 17:33
…to main � Conflicts: � README.md
…ess-list-3 # Conflicts: # pkg/controller/atlasproject/ipaccess_list.go # pkg/controller/atlasproject/ipaccess_list_test.go # pkg/controller/workflow/reason.go # test/int/project_test.go
added 2 commits
February 8, 2021 21:09
…nto CLOUDP-78181-ip-access-list-2 # Conflicts: # pkg/controller/workflow/reason.go
added 10 commits
February 9, 2021 17:33
…nto CLOUDP-78181-ip-access-list-3 # Conflicts: # pkg/controller/atlasproject/ipaccess_list.go
leo-ri
approved these changes
Feb 10, 2021
vasilevp
suggested changes
Feb 10, 2021
Contributor
vasilevp
left a comment
vasilevp
left a comment
There was a problem hiding this comment.
Nice work, but I have some concerns over the CIDR check
Co-authored-by: Pavel Vasilev <explosere@gmail.com>
added 2 commits
February 10, 2021 12:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 3 of ip access list support. Should be reviewed after #91
Adds more tests and the functionality to handle expired IP Access Lists
Expired IP Access lists are not sent to Atlas but instead are written to the status