fix notarizing code #277
Merged
fix notarizing code #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nammn
force-pushed
the
other-missing-things-2
branch
from
11a9c98 to
2d67be7
Compare
nammn
commented
Mar 6, 2024
| tasks: | ||
| - name: package_goreleaser | ||
| git_tag_only: true |
Collaborator
Author
There was a problem hiding this comment.
according to our evergreen setting page and this documentation: https://docs.devprod.prod.corp.mongodb.com/evergreen/Project-Configuration/Project-and-Distro-Settings/#triggering-versions-with-git-tags this should suffice.
mms-build-account is part of the allowed users to create tags. So we will have the following release process:
- mms-build-account creates a new release tag
- evergreen picks that up and will run this tasks/variants
- profit? 💸
nammn
commented
Mar 6, 2024
| - macos_notary_keyid | ||
| - macos_notary_secret | ||
| - workdir | ||
| - triggered_by_git_tag |
Collaborator
Author
There was a problem hiding this comment.
${triggered_by_git_tag} is the name of the tag that triggered this version, if applicable
nammn
commented
Mar 6, 2024
| <<: *go_env | ||
| MACOS_NOTARY_KEY: ${macos_notary_keyid} | ||
| MACOS_NOTARY_SECRET: ${macos_notary_secret} | ||
| GORELEASER_CURRENT_TAG: ${triggered_by_git_tag} |
Collaborator
Author
There was a problem hiding this comment.
just copy paste in what we had prior
mircea-cosbuc
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).Summary
fixes notarzing code
evg: https://spruce.mongodb.com/task/mongodb_enterprise_kubernetes_release_mcli_package_goreleaser_patch_b0a80faa1870a0b6432d63897f9397130d933768_65e7ffde2fbabe21948a9640_24_03_06_05_32_14/logs?execution=0
downloading https://github.com/mongodb/mongodb-enterprise-kubernetes/releases/tag/untagged-935fdcdf7b8d6f2acf91 shows that the binary works without mac complaining.