Skip to content

CLOUDP-242559 - expose readinessProbe settings, add documentation #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2024
Merged

CLOUDP-242559 - expose readinessProbe settings, add documentation #1566

merged 2 commits into from
Jun 25, 2024

Conversation

@nammn
Copy link
Collaborator

@nammn nammn commented Jun 25, 2024

Summary:

This PR adds the following:

  • inverting bool logic of agent configuration (easier for the eyes)
  • expose readinessProbe env var settings
  • document readinessProbe settings

All Submissions:

  • Have you opened an Issue before filing this PR?
  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@nammn nammn changed the title expose readinessProbe settings, add documentation CLOUDP-242559 - expose readinessProbe settings, add documentation Jun 25, 2024
mircea-cosbuc
mircea-cosbuc approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@mircea-cosbuc mircea-cosbuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nammn nammn marked this pull request as ready for review June 25, 2024 10:58
@nammn nammn merged commit 83a7e14 into master Jun 25, 2024
@nammn nammn deleted the add-logging-doc branch June 25, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mircea-cosbuc mircea-cosbuc mircea-cosbuc approved these changes

@lsierant lsierant Awaiting requested review from lsierant lsierant is a code owner

@slaskawi slaskawi Awaiting requested review from slaskawi

@Julien-Ben Julien-Ben Awaiting requested review from Julien-Ben Julien-Ben is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nammn @mircea-cosbuc