-
Notifications
You must be signed in to change notification settings - Fork 521
move Mypy to GitHub action #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move Mypy to GitHub action #323
Conversation
| - name: Mypy linting | ||
| uses: jpetrucciani/mypy-check@master | ||
| with: | ||
| path: scripts/*/*.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't 100% the same as before.
Before we were using some ugly bash magic to get all python files, we can't do that with this (or other github actions) and we need to either specify the folders containing python files or some magic globbing like this.
A glob that would work would be **/*.py but that syntax breaks github actions :(
Three possibilities here:
- Trust that all python files will always be in
scripts/*/or that we will remember to change this - Close this PR and leave mypy checks in evg
- Create a docker image that works for us
I'm open to both 1 and 2, I won't have time to do 3 for sure :)
rodrigovalin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I agree with option 1). There should not be Python files scattered around the codebase. If they are all kept in scripts then I think that's fine.
chatton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @rodrigovalin , everything being under scripts makes a lot of sense - this is great that we can move away from our own bash scripts and use github actions, nice job!
This moves also mypy to github actions, with a caveat :(
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).