Skip to content

Conversation

@bznein
Copy link
Contributor

@bznein bznein commented Feb 4, 2021

This moves also mypy to github actions, with a caveat :(

All Submissions:

  • Have you opened an Issue before filing this PR?
  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

- name: Mypy linting
uses: jpetrucciani/mypy-check@master
with:
path: scripts/*/*.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't 100% the same as before.
Before we were using some ugly bash magic to get all python files, we can't do that with this (or other github actions) and we need to either specify the folders containing python files or some magic globbing like this.

A glob that would work would be **/*.py but that syntax breaks github actions :(

Three possibilities here:

  1. Trust that all python files will always be in scripts/*/ or that we will remember to change this
  2. Close this PR and leave mypy checks in evg
  3. Create a docker image that works for us

I'm open to both 1 and 2, I won't have time to do 3 for sure :)

Copy link
Contributor

@rodrigovalin rodrigovalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I agree with option 1). There should not be Python files scattered around the codebase. If they are all kept in scripts then I think that's fine.

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @rodrigovalin , everything being under scripts makes a lot of sense - this is great that we can move away from our own bash scripts and use github actions, nice job!

@bznein bznein merged commit 2f2e368 into Move-black-formatting-to-github-action Feb 5, 2021
@bznein bznein deleted the mypy_github_action branch February 5, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants