Use emptyDir instead of volumefromsecret for keyfile #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
approved these changes
Mar 23, 2021
Contributor
chatton
left a comment
chatton
left a comment
There was a problem hiding this comment.
LGTM once all the tests have passed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the volume mount for the keyfile. Instead of mounting from a secret we mount an emptyDir, and then let the agent write the keyfile with correct permissions
This avoids the issue of having the volume mounted as read-only (which always happens when mounting volumes from secrets)
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).