CLOUDP-111968: Watch for changes in CA certificate #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mircea-cosbuc
requested review from
chatton,
ciprian-tibulca,
irajdeep,
priyolahiri and
rodrigovalin
as code owners
mircea-cosbuc
force-pushed
the
CLOUDP-111968_reconcile-on-ca-crt-change
branch
from
f362a5a to
5f9a8f5
Compare
irajdeep
reviewed
Mar 8, 2022
irajdeep
reviewed
Mar 8, 2022
irajdeep
reviewed
Mar 8, 2022
irajdeep
reviewed
Mar 8, 2022
Contributor
irajdeep
left a comment
irajdeep
left a comment
There was a problem hiding this comment.
LGTM -- with some minor comments inline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
This patch triggers a reconciliation loop when the CA certificate changes.
NOTE: The server certificates should be valid under both the old and new CA certificate chains for a zero-downtime update.
This also closes #874.
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).