flakiness: fix flaky scram auth #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1kola
approved these changes
Apr 23, 2025
Comment on lines
+1711
to
+1730
| def processes_are_ready(): | ||
| auto_status = KubernetesTester.get_automation_status() | ||
| goal_version = auto_status.get("goalVersion") | ||
|
|
||
| logger.info(f"Checking if all processes have reached goal version: {goal_version}") | ||
| processes_not_ready = [] | ||
| for process in auto_status.get("processes", []): | ||
| process_name = process.get("name", "unknown") | ||
| process_version = process.get("lastGoalVersionAchieved") | ||
| if process_version != goal_version: | ||
| logger.info(f"Process {process_name} at version {process_version}, expected {goal_version}") | ||
| processes_not_ready.append(process_name) | ||
|
|
||
| all_processes_ready = len(processes_not_ready) == 0 | ||
| if all_processes_ready: | ||
| logger.info("All processes have reached the goal version") | ||
| else: | ||
| logger.info(f"{len(processes_not_ready)} processes have not yet reached the goal version") | ||
|
|
||
| return all_processes_ready |
Contributor
There was a problem hiding this comment.
This bit is very similar to check_version_and_processes in #19. Would be great to unify.
Collaborator
Author
There was a problem hiding this comment.
100% will rebase the other one, after merging this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proof of Work
Checklist
Reminder (Please remove this when merging)