Search: remove external.tls.enabled #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anand Singh <anand.singh@mongodb.com> Co-authored-by: Yavor Georgiev <fealebenpae@users.noreply.github.com>
Co-authored-by: Vivek Singh <vsingh.ggits.2010@gmail.com>
anandsyncs
changed the base branch from
master
to
search/public-preview-operator
MCK 1.3.1 Release Notes |
anandsyncs
commented
Sep 11, 2025
fealebenpae
approved these changes
Sep 12, 2025
anandsyncs
added
the
skip-changelog
lsierant
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors the TLS configuration for MongoDB Search resources by removing the
enabledboolean flag and relying solely on the presence or absence of TLS configuration objects to determine if TLS should be enabled. It also updates the CRD schemas, controller logic, tests, and documentation to reflect this change, and clarifies the usage of CA certificates for external mongod sources.API and CRD schema changes:
enabledboolean from bothspec.security.tlsandspec.source.external.tls, making TLS activation dependent on whether the TLS configuration is provided. Updated required fields and descriptions for CA certificates in the CRDs (config/crd/bases/mongodb.com_mongodbsearch.yaml,helm_chart/crds/mongodb.com_mongodbsearch.yaml,public/crds.yaml). [1] [2] [3] [4] [5] [6]Enabledfield fromExternalMongodTLSandTLS, clarified CA certificate documentation, and madeSecurity.TLSan optional pointer. (api/v1/search/mongodbsearch_types.go)Controller logic updates:
Enabledflag when determining TLS behavior in reconciliation and config generation. (controllers/operator/mongodbsearch_controller.go,controllers/searchcontroller/external_search_source.go,controllers/searchcontroller/mongodbsearch_reconcile_helper.go) [1] [2] [3] [4]Test and documentation updates:
enabledfield in TLS configurations and to use the new structure. (docker/mongodb-kubernetes-tests/tests/search/search_community_external_mongod_basic.py,docker/mongodb-kubernetes-tests/tests/search/search_community_external_mongod_tls.py,docker/mongodb-kubernetes-tests/tests/search/search_enterprise_tls.py,docs/search/04-search-external-mongod/README.md,docs/search/04-search-external-mongod/code_snippets/04_0320_create_mongodb_search_resource.sh) [1] [2] [3] [4] [5]Evergreen build changes:
.evergreen-snippets.yml) [1] [2]Proof of Work
Tests pass
Checklist
skip-changeloglabel if not needed