Skip to content

Enable mistakenly disabled image signing + conform to new cosign version #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

Enable mistakenly disabled image signing + conform to new cosign version #563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scripts/release/build/image_signing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,8 @@ def sign_image(repository: str, tag: str) -> None:
"sign",
f"--key={pkcs11_uri}",
f"--sign-container-identity={image}",
f"--use-signing-config=false",
f"--new-bundle-format=false",
f"--tlog-upload=false",
image_ref,
]
Expand Down
2 changes: 1 addition & 1 deletion scripts/release/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ def main():
parser.add_argument(
"-s",
"--sign",
action="store_true",
action=argparse.BooleanOptionalAction,
Copy link
Collaborator Author

@MaciejKaras MaciejKaras Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sign was always set and it was overriding the value from build_info.json:

sign = args.sign if args.sign is not None else image_build_info.sign

help="If set force image signing. Default is to infer from build scenario.",
)
parser.add_argument(
Expand Down
Loading