CLOUDP-235689: CI fixes for Multi-Cluster Replica Set unification feature branch #612
Conversation
It was breaking a lot of unit end e2e tests.
|
There is an existing patch(es) for this commit SHA: Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'. |
m1kola
changed the base branch from
master
to
mc-rs-unification-feature-branch
m1kola
requested review from
Julien-Ben,
MaciejKaras,
filipcirtog and
viveksinghggits
and removed request for
a team
| podName := GetMultiPodName(stsName, clusterNum, podNum) | ||
| headlessService := GetMultiHeadlessServiceName(stsName, clusterNum) | ||
| return fmt.Sprintf("%s.%s.%s.svc.%s", podName, headlessService, namespace, domain) | ||
| return fmt.Sprintf("%s.%s.svc.%s", GetMultiServiceName(stsName, clusterNum, podNum), namespace, domain) |
There was a problem hiding this comment.
Reverting back to this (original, as seen in master) code fixes most of the tests, but breaks MongoDB-based multi-cluster.
Controller for MongoDBMultiCluster generates hostnames like this:
multi-replica-set-0-0-svc.mongodb-test.svc.cluster.local
multi-replica-set-1-0-svc.mongodb-test.svc.cluster.local
multi-replica-set-2-0-svc.mongodb-test.svc.cluster.local
But the controller for MongoDB multi-cluster replica sets creates hostnames like this even with the revert:
multi-replica-set-0-0.multi-replica-set-0-svc.mongodb-test.svc.cluster.local
multi-replica-set-1-0.multi-replica-set-1-svc.mongodb-test.svc.cluster.local
multi-replica-set-2-0.multi-replica-set-2-svc.mongodb-test.svc.cluster.local
Still trying to understand why.
1 participant
Summary
getReplicaSetMultiClusterMapfunction to make the linter happyGetMultiServiceFQDNback to it's original version as it was breaking a lot of unit and e2e tests.Proof of Work
This will break
e2e_multi_cluster_new_replica_set_scale_up(expected as this is a - WIP test), but fix other multi-cluster related tests for existing APIs.Checklist
skip-changeloglabel if not needed