MONGOID-5887 Include server hint for aggregate operations #6035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where hints were not being passed to MongoDB aggregate operations in Mongoid. When a hint was specified using .hint() on a criteria (e.g., Person.hint({ age: 1 }).aggregates(:age)), the hint was not included in the MongoDB command.
- Adds hint parameter to the aggregate operation call
- Includes comprehensive test coverage for hint functionality in aggregate operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/mongoid/contextual/aggregable/mongo.rb | Updates aggregates method to include hint parameter from view |
| spec/mongoid/contextual/aggregable/mongo_spec.rb | Adds test cases to verify hint inclusion in aggregate commands |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
comandeo-mongo
approved these changes
Sep 15, 2025
jamis
added a commit
to jamis/mongoid
that referenced
this pull request
Sep 15, 2025
jamis
added a commit
that referenced
this pull request
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a hint was specified for an aggregate operation (e.g.
Person.hint({ age: 1 }).aggregates(:age)) the hint was not being included with the constructed command. This PR fixes that.