-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(NODE-7043, NODE-7217)!: adopt mongodb-client-encryption v7 #4705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is an existing patch(es) for this commit SHA: Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'. |
superceded by #4694 |
There is an existing patch(es) for this commit SHA: Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'. |
1c150e4
to
b67d4ef
Compare
b67d4ef
to
a70b1f5
Compare
...ion/client-side-encryption/client_side_encryption.prose.22.range_explicit_encryption.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Summary of Changes
This PR is a small feature branch containing the driver changes corresponding to breaking mongodb-client-encryption changes. It contains:
enableMultipleCollInfo
(it now defaults to 'enabled')Warning
Do not merge this PR until all mongodb-client-encryption changes are completed, an alpha has been released, and this PR is updated to use the alpha.
Notes for Reviewers
The changes in mongodb-js/mongodb-client-encryption#102 must be released before CI passes fully. The custom dependency tests use the changes from my other PR and should be passing.
What is the motivation for this change?
Release Highlight
All Encryption-Related Errors Subclass MongoError
The driver aims to ensure that all errors it throws are subclasses of MongoError. However, when using CSFLE or QE, the driver's encryption implementation sometimes could throw errors that were not instances of MongoError.
Now, all errors thrown during encryption are subclasses of MongoError.
Double check the following
npm run check:lint
)type(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript