Skip to content

test(NODE-6493): sync runCursorCommand fixes #4312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 4, 2024
Merged

test(NODE-6493): sync runCursorCommand fixes #4312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
33fed11
test(NODE-6493): sync runCursorCommand fixes
nbbeeken Nov 4, 2024
853a8f4
chore: sync-ed test that was changed
nbbeeken Nov 4, 2024
c6ae429
chore: reset operations
nbbeeken Nov 4, 2024
e7f2d07
chore
nbbeeken Nov 4, 2024
396b19c
chore: unskip Non-tailable cursor lifetime remaining timeoutMS applie…
nbbeeken Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions test/integration/client-side-operations-timeout/client_side_operations_timeout.spec.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,8 @@ import { runUnifiedSuite } from '../../tools/unified-spec-runner/runner';
const skippedSpecs = {};

const skippedTests = {
'Tailable cursor iteration timeoutMS is refreshed for getMore - failure': 'TODO(NODE-6493)',
'Tailable cursor awaitData iteration timeoutMS is refreshed for getMore - failure':
'TODO(NODE-6493)',
'command is not sent if RTT is greater than timeoutMS': 'TODO(DRIVERS-2965)',
'Non=tailable cursor iteration timeoutMS is refreshed for getMore if timeoutMode is iteration - failure':
'TODO(DRIVERS-2965)',
'Non-tailable cursor lifetime remaining timeoutMS applied to getMore if timeoutMode is unset':
'Non-tailable cursor iteration timeoutMS is refreshed for getMore if timeoutMode is iteration - failure':
'TODO(DRIVERS-2965)',
'maxTimeMS value in the command is less than timeoutMS':
'TODO(DRIVERS-2970): see modified test in unified-csot-node-specs',
Expand Down
4 changes: 2 additions & 2 deletions test/spec/client-side-operations-timeout/runCursorCommand.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@
},
"collection": "collection",
"maxTimeMS": {
"$$exists": true
"$$exists": false
}
}
}
Expand All @@ -210,7 +210,7 @@
]
},
{
"description": "Non=tailable cursor iteration timeoutMS is refreshed for getMore if timeoutMode is iteration - failure",
"description": "Non-tailable cursor iteration timeoutMS is refreshed for getMore if timeoutMode is iteration - failure",
"runOnRequirements": [
{
"serverless": "forbid"
Expand Down
11 changes: 6 additions & 5 deletions test/spec/client-side-operations-timeout/runCursorCommand.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ tests:
runOnRequirements:
- serverless: forbid
operations:
# Block find/getMore for 15ms.
# Block find/getMore for 60ms.
- name: failPoint
object: testRunner
arguments:
Expand All @@ -83,8 +83,9 @@ tests:
blockConnection: true
blockTimeMS: 60
# Run a find with timeoutMS less than double our failPoint blockTimeMS and
# batchSize less than the total document count will cause a find and a getMore to be sent.
# Both will block for 60ms so together they will go over the timeout.
# batchSize less than the total document count will cause a find and a
# getMore to be sent. Both will block for 60ms so together they will go
# over the timeout.
- name: runCursorCommand
object: *db
arguments:
Expand All @@ -106,12 +107,12 @@ tests:
command:
getMore: { $$type: [int, long] }
collection: *collection
maxTimeMS: { $$exists: true }
maxTimeMS: { $$exists: false }

# If timeoutMode=ITERATION, timeoutMS applies separately to the initial find and the getMore on the cursor. Neither
# command should have a maxTimeMS field. This is a failure test. The "find" inherits timeoutMS=100 and "getMore"
# commands are blocked for 60ms, causing iteration to fail with a timeout error.
- description: Non=tailable cursor iteration timeoutMS is refreshed for getMore if timeoutMode is iteration - failure
- description: Non-tailable cursor iteration timeoutMS is refreshed for getMore if timeoutMode is iteration - failure
runOnRequirements:
- serverless: forbid
operations:
Expand Down