Skip to content

Conversation

@baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Oct 10, 2025

Description

Summary of Changes

This PR removes support for the noResponse option. noResponse was only used by endSessions while executing MongoClient.close(). Now, we use an unacknowledged write instead to avoid waiting for the server's response.

Notes for Reviewers

What is the motivation for this change?

Release Highlight

CommandOptions.noResponse option removed

This option was never intended to be public, and never worked properly for user-facing APIs. It has now been removed.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review October 10, 2025 18:39
@baileympearson baileympearson requested a review from a team as a code owner October 10, 2025 18:39
@dariakp dariakp self-assigned this Oct 14, 2025
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 14, 2025
@dariakp dariakp merged commit 9e9059a into mongodb:main Oct 14, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants