Skip to content

Conversation

@durran
Copy link
Member

@durran durran commented Oct 20, 2025

Description

Dropping collections will no longer fail when the namespace isn't found.

Summary of Changes

  • Updates collection.drop() to return false if a ns is not found.
  • Updates all locations in the driver that implemented this logic.
Notes for Reviewers

The AC on the ticket said to only update behaviour in the unified runner, but I took this opportunity to pull it out everywhere.

What is the motivation for this change?

NODE-4243

Release Highlight

Dropping a Collection No Longer Throws When NS not Found

This will now return false instead.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review October 20, 2025 12:40
@durran durran requested a review from a team as a code owner October 20, 2025 12:40
@baileympearson baileympearson self-assigned this Oct 20, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 20, 2025
@dariakp dariakp self-requested a review October 20, 2025 20:38
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Oct 20, 2025
@dariakp dariakp merged commit a8d7c5f into main Oct 21, 2025
25 of 27 checks passed
@dariakp dariakp deleted the NODE-4243 branch October 21, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants