fix(NODE-7290): use valueof for error code check #4791
Merged
+65
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
addaleax
approved these changes
Nov 13, 2025
dariakp
added
the
Primary Review
dariakp
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts the error code to a primitive JS number when checking reauthentication.
Summary of Changes
Calls
valueOf()on the error code, which will return the JS number if it is the number primitive, or in the case where it is anInt32will return the primitive number.What is the motivation for this change?
NODE-7290
Release Highlight
OIDC Reauthentication now works with
promoteValues: falseIn the case where the MongoClient is configured with
promoteValues: false, reauthentication will now properly succeed.Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript