Skip to content

refactor(NODE-7302): remove dependency on uri.parse() #4798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2025
+0 −67
Merged

refactor(NODE-7302): remove dependency on uri.parse() #4798

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ff1d88
feat(NODE-7302): remove dependency on uri.parse()
durran Nov 17, 2025
5223a7c
refactor: remove dead code
durran Nov 18, 2025
db4708b
refactor: remove request options
durran Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 0 additions & 67 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ import { type EventEmitter } from 'events';
import { promises as fs } from 'fs';
import * as http from 'http';
import { clearTimeout, setTimeout } from 'timers';
import * as url from 'url';
import { URL } from 'url';
import { promisify } from 'util';

import { deserialize, type Document, ObjectId, resolveBSONOptions } from './bson';
Expand Down Expand Up @@ -1161,13 +1159,6 @@ export function checkParentDomainMatch(address: string, srvHost: string): void {
}
}

interface RequestOptions {
json?: boolean;
method?: string;
timeout?: number;
headers?: http.OutgoingHttpHeaders;
}

/**
* Perform a get request that returns status and body.
* @internal
Expand Down Expand Up @@ -1200,64 +1191,6 @@ export function get(
});
}

export async function request(uri: string): Promise<Record<string, any>>;
export async function request(
uri: string,
options?: { json?: true } & RequestOptions
): Promise<Record<string, any>>;
export async function request(
uri: string,
options?: { json: false } & RequestOptions
): Promise<string>;
export async function request(
uri: string,
options: RequestOptions = {}
): Promise<string | Record<string, any>> {
return await new Promise<string | Record<string, any>>((resolve, reject) => {
const requestOptions = {
method: 'GET',
timeout: 10000,
json: true,
...url.parse(uri),
...options
};

const req = http.request(requestOptions, res => {
res.setEncoding('utf8');

let data = '';
res.on('data', d => {
data += d;
});

res.once('end', () => {
if (options.json === false) {
resolve(data);
return;
}

try {
const parsed = JSON.parse(data);
resolve(parsed);
} catch {
// TODO(NODE-3483)
reject(new MongoRuntimeError(`Invalid JSON response: "${data}"`));
}
});
});

req.once('timeout', () =>
req.destroy(
new MongoNetworkTimeoutError(
`Network request to ${uri} timed out after ${options.timeout} ms`
)
)
);
req.once('error', error => reject(error));
req.end();
});
}

/** @internal */
export const DOCUMENT_DB_CHECK = /(\.docdb\.amazonaws\.com$)|(\.docdb-elastic\.amazonaws\.com$)/;
/** @internal */
Expand Down