Skip to content

Conversation

lovisaberggren
Copy link
Collaborator

@lovisaberggren lovisaberggren commented Jan 22, 2025

Proposed changes

  • Added test for runMetricsCollectionJob() with example input to validate the output results are what we expect (runs for a copy of the current oas and only one ipa rule)

Also did some refactoring:

  • Moved runMetricsCollectionJob() to it's own module for easier testing
  • Refactored runMetricsCollectionJob() to take all possible config values for easier configuration and testing
  • Added scripts folder for the metrics scripts, for example runMetricCollection.js which calls runMetricsCollectionJob() and dataDump.js
  • Removed defaultSpectralReportFile and defaultSpectralOutputFile used in the metric collection script, since the results aren't used

Jira ticket: CLOUDP-295956

@lovisaberggren lovisaberggren marked this pull request as ready for review January 22, 2025 14:31
@lovisaberggren lovisaberggren requested a review from a team as a code owner January 22, 2025 14:31
Copy link
Collaborator

@yelizhenden-mdb yelizhenden-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work 💯

@lovisaberggren lovisaberggren merged commit 4784d9d into main Jan 22, 2025
13 checks passed
@lovisaberggren lovisaberggren deleted the CLOUDP-295956 branch January 22, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants