CLOUDP-295956: Refactor + add testing for IPA metrics collection #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
runMetricsCollectionJob()
with example input to validate the output results are what we expect (runs for a copy of the current oas and only one ipa rule)Also did some refactoring:
runMetricsCollectionJob()
to it's own module for easier testingrunMetricsCollectionJob()
to take all possible config values for easier configuration and testingscripts
folder for the metrics scripts, for examplerunMetricCollection.js
which callsrunMetricsCollectionJob()
anddataDump.js
Jira ticket: CLOUDP-295956