CLOUDP-296909: Add some comments to the IPA release workflow #390
Conversation
| # Checks the last workflow run, and decides whether the IPA release metrics should be uploaded or | ||
| # skipped. The release-IPA-metrics job only runs if the last release was not today and did not fail. | ||
| pre-IPA-metrics-release-checks: |
There was a problem hiding this comment.
Do you have a Jira ticket where you plan to run the workflow as part of the release process? Btw, you could just update this workflow to run automatically when a specific file is updated on the master branch
on:
push:
paths:
- openapi/v2.jsonThere was a problem hiding this comment.
We have already added it here: #388
Btw, you could just update this workflow to run automatically when a specific file is updated on the master branch
That could be an option, though this file corresponds to the prod oas right? Since we wanted to get the metrics from the dev oas I think we need to do it during the dev oas release
There was a problem hiding this comment.
We have already added it here
Ah okay, I missed it. I am still of the opinion that you don't need to add it to the release workflow as this makes it more complex🤔 IMO the easiest approach would be to run the workflow once a day (end of the day) and file an issue on the repo if the push fails. The Foas Release process is getting more and more complex + this approach forces us to run this workflow multiple times per day (~every hour if the spec has changed on master) while we just need to run it once.
No need to address anything here, it is more me thinking loud.
There was a problem hiding this comment.
Yeah I see your point, it's something we can consider as an improvement perhaps during the new epic IPA: validations applied, or as a follow up during a non-epic week, CC: @yelizhenden-mdb
Proposed changes
Adds some comments describing the IPA release workflow and what it does. Addresses comments in previous PR
Jira ticket: CLOUDP-296909