CLOUDP-304706: add a retry step to the FOAS release process #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
approved these changes
Mar 6, 2025
blva
reviewed
Mar 6, 2025
| retry-handler: | ||
| needs: [ release, release-postman, release-changelog] | ||
| if: ${{ always() && contains(needs.*.result, 'failure') }} | ||
| if: ${{ always() && contains(needs.*.result, 'failure') && fromJSON(github.run_attempt) < 3}} |
There was a problem hiding this comment.
nit: does GH actions not have some standard support for retries? would be nice if we didn't have to maintain our own retry logic
There was a problem hiding this comment.
There are some 3rd party Actions but they don't allow to restart a complete worflow. Let me know if you find something! we can always update this logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-304706
Description:
This pull request introduces a retry mechanism for handling failures in the release workflow. The most important changes include adding a new job to retry the release process and updating the failure handler to account for this new retry mechanism.
Retry mechanism for release workflow:
.github/workflows/release-spec.yml: Added a newretry-handlerjob that attempts to rerun the release workflow up to three times if it fails. Updated thefailure-handlerjob to depend on theretry-handlerand only run if theretry-handleris skipped..github/workflows/retry-handler.yml: Created a new workflow file to define theretry-handlerjob, which reruns the failed workflow using the GitHub CLI.I tested the changes in my fork: https://github.com/andreaangiolillo/openapi-test/actions/runs/13703067837