CLOUDP-305844: fix branded_preview to avoid listing v2.json/v2.yaml files #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
reviewed
Mar 11, 2025
Comment on lines
+23
to
+28
| if [[ "${version}" == *"private"* ]]; then | ||
| all_urls+=("https://raw.githubusercontent.com/mongodb/openapi/${branch_name:?}/openapi/v2/private/openapi-${version}.json") | ||
| all_urls+=("https://raw.githubusercontent.com/mongodb/openapi/${branch_name:?}/openapi/v2/private/openapi-${version}.yaml") | ||
| continue | ||
| fi | ||
|
|
There was a problem hiding this comment.
Suggested change
| if [[ "${version}" == *"private"* ]]; then | |
| all_urls+=("https://raw.githubusercontent.com/mongodb/openapi/${branch_name:?}/openapi/v2/private/openapi-${version}.json") | |
| all_urls+=("https://raw.githubusercontent.com/mongodb/openapi/${branch_name:?}/openapi/v2/private/openapi-${version}.yaml") | |
| continue | |
| fi |
do we want to add private preview though? I was under the impression that we didn't (note: public preview will be automatically added already)
There was a problem hiding this comment.
In the scope we only says that the access to the private preview spec will be within the mongodb/openapi repo. we don't mention branded_preview. I think is a nice addition since we could just share a link to the selected customers with the branded preview link. With that sad, I am open to remove it too
Update: we could also have a branded_private_preview
There was a problem hiding this comment.
no strong opinion from m side, easy enough to revisit
blva
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: CLOUDP-305844
Branded preview list v2.json and v2.yaml specs and the preview does not work for private preview specs.
This PR updates the branded_preview.sh logic to remove the v2.json|yaml files and to use the correct path for private preview specs