Skip to content

CLOUDP-304053: IPA-106:Create - The resource must be the request body (exclude readOnly:true and writeOnly:true) #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 14, 2025
Merged

CLOUDP-304053: IPA-106:Create - The resource must be the request body (exclude readOnly:true and writeOnly:true) #541

merged 10 commits into from
Mar 14, 2025

Conversation

@yelizhenden-mdb
Copy link
Collaborator

@yelizhenden-mdb yelizhenden-mdb commented Mar 14, 2025 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-304053

Refines the rule with the latest spec changes
Before comparing the schemas:

  • Remove readOnly:true properties from Get response
  • Remove writeOnly:true properties from Create request

Drive-by changes on the descriptions and error messages to follow the latest documentation format

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Changes to Spectral

  • I have read the README file for Spectral Updates

Further comments

@yelizhenden-mdb yelizhenden-mdb marked this pull request as ready for review March 14, 2025 15:45
@yelizhenden-mdb yelizhenden-mdb requested a review from a team as a code owner March 14, 2025 15:45
lovisaberggren
lovisaberggren approved these changes Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@lovisaberggren lovisaberggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two optional comments

@yelizhenden-mdb yelizhenden-mdb merged commit 0374a81 into main Mar 14, 2025
13 checks passed
@yelizhenden-mdb yelizhenden-mdb deleted the CLOUDP-304053 branch March 14, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtrocki wtrocki wtrocki approved these changes

@lovisaberggren lovisaberggren Awaiting requested review from lovisaberggren

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yelizhenden-mdb @wtrocki @lovisaberggren