CLOUDP-304945: Add xgen-IPA-107-update-method-response-is-get-method-response #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovisaberggren
commented
Mar 18, 2025
| - Paths with `x-xgen-IPA-exception` for this rule are excluded from validation | ||
| message: '{{error}} https://mdb.link/mongodb-atlas-openapi-validation#xgen-IPA-107-update-method-response-is-get-method-response' | ||
| severity: warn | ||
| given: '$.paths[*][put,patch].responses.200.content' |
There was a problem hiding this comment.
Realized we can do $.paths[*][put,patch] to cover multiple operations. In follow-up CLOUDP-307110 I will do the same for the rules above to not have multiple rules covering the same thing.
| testRule('xgen-IPA-106-create-method-response-is-get-method-response', [ | ||
| { | ||
| name: 'valid create requests', | ||
| name: 'valid create responses', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds rule
xgen-IPA-107-update-method-response-is-get-method-responseand tests. Also drive-by to correct the test forIPA106CreateMethodResponseIsGetMethodResponse.test.jswhere there were request bodies validated instead of response contents.Jira ticket: CLOUDP-304945
One violation currently. Will do combined follow-up PR to add exceptions for multiple "update method" related IPAs.