Skip to content

CLOUDP-306580: base types oneof #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2025
Merged

CLOUDP-306580: base types oneof #573

merged 3 commits into from
Mar 20, 2025

Conversation

@wtrocki
Copy link
Member

@wtrocki wtrocki commented Mar 19, 2025 •
edited
Loading

Proposed changes

Base types oneOf validator.

Found 0 violations to fix

🤗

Jira ticket: CLOUDP-306580

@wtrocki wtrocki requested a review from a team as a code owner March 19, 2025 19:10
yelizhenden-mdb
yelizhenden-mdb approved these changes Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@yelizhenden-mdb yelizhenden-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after IPA docs are generated including new rule. Thanks!
(It is surprising that CI job did not fail asking gen-ipa-docs)

@wtrocki
Copy link
Member Author

wtrocki commented Mar 19, 2025

LGTM after IPA docs are generated including new rule. Thanks!
(It is surprising that CI job did not fail asking gen-ipa-docs)

This PR depends on another one. I intend to generate docs later to avoid conflicts

Base automatically changed from CLOUDP-306580-oneOf to main March 20, 2025 12:31
@wtrocki
Copy link
Member Author

wtrocki commented Mar 20, 2025

Regenerated documentation only. No code changes.

@wtrocki wtrocki marked this pull request as draft March 20, 2025 12:50
@wtrocki
Copy link
Member Author

wtrocki commented Mar 20, 2025

Investigating issue when running specific validation.

@wtrocki
Copy link
Member Author

wtrocki commented Mar 20, 2025 •
edited
Loading

We do not have exceptions however in the current approach we will not be able to put exception without customization.
Making small adjustment to use component.schemas as root.

@wtrocki wtrocki requested a review from yelizhenden-mdb March 20, 2025 13:43
@wtrocki wtrocki marked this pull request as ready for review March 20, 2025 13:43
@wtrocki
Copy link
Member Author

wtrocki commented Mar 20, 2025 •
edited
Loading

Exceptions are still needed:

Filtering violations for rule ID: xgen-IPA-125-oneOf-must-have-discriminator
Found 19 violations to fix

npm run ipa-filter-violations xgen-IPA-125-oneOf-no-base-types https://raw.githubusercontent.com/mongodb/openapi/refs/heads/dev/openapi/.raw/v2.yaml
Found 4 violations to fix

yelizhenden-mdb
yelizhenden-mdb approved these changes Mar 20, 2025
View reviewed changes
Copy link
Collaborator

@yelizhenden-mdb yelizhenden-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wtrocki wtrocki merged commit 8411c91 into main Mar 20, 2025
7 checks passed
@wtrocki wtrocki deleted the CLOUDP-306581 branch March 20, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yelizhenden-mdb yelizhenden-mdb yelizhenden-mdb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wtrocki @yelizhenden-mdb