Skip to content

Conversation

@yelizhenden-mdb
Copy link
Collaborator

@yelizhenden-mdb yelizhenden-mdb commented Mar 24, 2025

Proposed changes

Jira ticket: CLOUDP-271999
(and other tickets CLOUDP-272000 and CLOUDP-272001)

Fix on the IPA-112 rule implementations:
If the path to property is a resolved version of a schema reference, skip it to prevent duplicate violations. The referenced schemas will be validated separately

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Changes to Spectral

  • I have read the README file for Spectral Updates

Further comments

@yelizhenden-mdb yelizhenden-mdb marked this pull request as ready for review March 24, 2025 14:30
@yelizhenden-mdb yelizhenden-mdb requested a review from a team as a code owner March 24, 2025 14:30
Copy link
Collaborator

@lovisaberggren lovisaberggren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yelizhenden-mdb yelizhenden-mdb merged commit e050b2d into main Mar 24, 2025
8 checks passed
@yelizhenden-mdb yelizhenden-mdb deleted the CLOUDP-271999 branch March 24, 2025 16:23
- '$.paths..requestBody.content[?(@property.match(/json$/i))].schema..properties[*]~'
- '$.paths..responses..content[?(@property.match(/json$/i))].schema..properties[*]~'
- '$.components.schemas..properties'
- '$.paths..requestBody.content[?(@property.match(/json$/i))].schema..properties'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] JSON filtering can be done as option for rule configuration and checked in code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants