fix(ipa): Update override logic to be more lenient #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovisaberggren
approved these changes
Aug 1, 2025
| */ | ||
| export function hasMethodVerbOverride(object, verb) { | ||
| return hasVerbOverride(object) && object[VERB_OVERRIDE_EXTENSION].verb === verb; | ||
| return hasVerbOverride(object) && object[VERB_OVERRIDE_EXTENSION].verb.startsWith(verb); |
There was a problem hiding this comment.
[Nit] Can you update the description of the function as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Following discussions on accommodating customer experience with Operation ID overrides, the logic has been updated to:
x-xgen-method-verb-overrideusage on non-custom methods This change allows for nouns that do not appear in the resource path to be included in the Operation ID. ie:getGroupStream->getGroupStreamInstancex-xgen-operation-id-overrideto be present on any length of Operation Id. This override is still required for ids of length > 4, but now it can also be used to change shorter ids. ie:getGroupStreamInstance->getStreamInstance.Jira ticket: CLOUDP-335029