STITCH-1732 Create React Native SDK #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniels
approved these changes
Jul 27, 2018
Contributor
edaniels
left a comment
edaniels
left a comment
There was a problem hiding this comment.
LGTM. Just some random comments.
| expect(stitchUserProfileImpl.pictureUrl).toEqual(PICTURE_URL); | ||
| expect(stitchUserProfileImpl.minAge).toEqual(Number.parseInt(MIN_AGE)); | ||
| expect(stitchUserProfileImpl.maxAge).toEqual(Number.parseInt(MAX_AGE)); | ||
| expect(stitchUserProfileImpl.minAge).toEqual(Number.parseInt(MIN_AGE, 10)); |
Contributor
Author
There was a problem hiding this comment.
new linter warning
| * Initializes the default StitchAppClient associated with the application. | ||
| * | ||
| * @param clientAppId The desired clientAppId for the client. | ||
| * @param config Additional configuration options (optional). |
| * @param clientAppId The desired clientAppId for the client. | ||
| * @param config Additional configuration options (optional). | ||
| */ | ||
| public static initializeAppClient( |
| StitchUserIdentity, | ||
| Storage, | ||
| MemoryStorage, | ||
| RNAsyncStorage, |
Contributor
There was a problem hiding this comment.
Do you actually want to expose this to users?
Contributor
Author
There was a problem hiding this comment.
No, good catch. I was using it when debugging earlier but I can get rid of it here.
| { | ||
| "name": "mongodb-stitch-react-native-coretest", | ||
| "version": "4.0.9", | ||
| "description": "web core test", |
Contributor
There was a problem hiding this comment.
update descs in these new files
edaniels
reviewed
Jul 27, 2018
packages/react-native/core/README.md
Outdated
|
|
||
| This package contains the React Native Core. | ||
|
|
||
| **For more information on using this on a server, see the [mongodb-stitch-react-native-sdk](https://www.npmjs.com/package/mongodb-stitch-react-native-sdk) package.** No newline at end of file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready to review, and almost ready to publish, I just need to update the READMEs.
Main things to note:
mongodb-stitch-react-native-coreareRNAsyncStorage.tsandStitch.ts(since we now have async client initialization),react-nativeand several other packages are in a particular project'snode_modulesso I've added some packages tonohoistinlerna.json. This only affects the react native projects.react-nativeas a dependency, it is only a peer dependency ofmongodb-stitch-react-native-core. React Native's packager doesn't work when the RN package exists in multiple places in anode_modulesdirectory. For the purposes of tests, some packages listreact-nativeas a devDependency."testURL": "http://localhost/"if we want to uselocalStoragein tests.