Skip to content

STITCH-2229 Change minAge and maxAge from Int to String #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamchel merged 1 commit into from
Nov 27, 2018
Merged

STITCH-2229 Change minAge and maxAge from Int to String #179

adamchel merged 1 commit into from
Nov 27, 2018

Conversation

@adamchel
Copy link
Contributor

@adamchel adamchel commented Nov 27, 2018

No description provided.

@adamchel adamchel requested review from dkaminsky and jsflax November 27, 2018 19:47
dkaminsky
dkaminsky approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@dkaminsky dkaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Nov 27, 2018

Coverage Status

Coverage remained the same at 77.154% when pulling 6799ecf on adamchel:STITCH-2229 into 0c23511 on mongodb:master.

@adamchel adamchel merged commit da18ca6 into mongodb:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jsflax jsflax jsflax approved these changes

@dkaminsky dkaminsky dkaminsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adamchel @coveralls @jsflax @dkaminsky