DOCSP-3944 Update README, add links #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbush
force-pushed
the
docsp-3944-readme
branch
from
46e82fd to
0c299d2
Compare
adamchel
approved these changes
Jan 28, 2019
MongoCaleb
approved these changes
Jan 29, 2019
MongoCaleb
left a comment
MongoCaleb
left a comment
There was a problem hiding this comment.
A couple of small notes that I put in the js sdk but apply to the other, as well.
| }) | ||
| ``` | ||
|
|
||
| Assuming you've configured your Stitch application to have a function named "echoArg" that returns its argument, you should see a message like: |
There was a problem hiding this comment.
Is it worth showing that function here, too?
packages/browser/sdk/README.md
Outdated
| This library depends on [js-bson](https://www.npmjs.com/package/js-bson). | ||
| The Stitch SDK depends on [bson](https://www.npmjs.com/package/bson). | ||
|
|
||
| As a convenience, the SDK includes the `BSON` library, and you can import it as you would import other classes and values from the SDK. |
There was a problem hiding this comment.
So we say the Stitch SDK depends on it, and then we say the SDK includes it...
- Adds more links to other docs in the three READMEs - Attempt to clarify and streamline some of the content
cbush
force-pushed
the
docsp-3944-readme
branch
from
0c299d2 to
8820a43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staged:
https://docs-mongodbcom-staging.corp.mongodb.com/stitch/bush/docsp-3944-readme/sdk/js/index.html
https://docs-mongodbcom-staging.corp.mongodb.com/stitch/bush/docsp-3944-readme/sdk/js-server/index.html
https://docs-mongodbcom-staging.corp.mongodb.com/stitch/bush/docsp-3944-readme/sdk/js-react-native/index.html