Find one and... #237
Merged
Find one and... #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchel
approved these changes
Feb 26, 2019
Contributor
adamchel
left a comment
adamchel
left a comment
There was a problem hiding this comment.
Great work! Nice comprehensive tests too. Just had a few nits.
Also, when you create PRs in the future, please include the ticket number and a description of the ticket/the changes you made in the title. When you squash and merge, please name the commit something like
STITCH-2526 add support for findOneAnd{Update,Replace,Delete}
packages/browser/services/mongodb-remote/__tests__/RemoteMongoClientIntTests.ts
Outdated
Show resolved
Hide resolved
packages/browser/services/mongodb-remote/__tests__/RemoteMongoClientIntTests.ts
Outdated
Show resolved
Hide resolved
packages/browser/services/mongodb-remote/__tests__/RemoteMongoClientIntTests.ts
Outdated
Show resolved
Hide resolved
packages/browser/services/mongodb-remote/__tests__/RemoteMongoClientIntTests.ts
Outdated
Show resolved
Hide resolved
packages/core/services/mongodb-remote/src/RemoteFindOneAndDeleteOptions.ts
Outdated
Show resolved
Hide resolved
packages/core/services/mongodb-remote/src/RemoteFindOneAndUpdateOptions.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Though it looks like evergreen is failing due to some |
tkaye407
commented
Feb 28, 2019
packages/browser/services/mongodb-remote/__tests__/RemoteMongoClientIntTests.ts
Outdated
Show resolved
Hide resolved
tkaye407
commented
Feb 28, 2019
packages/react-native/services/mongodb-remote/__tests__/RemoteMongoClientIntTests.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.